3D models during briefings cause crash on launch

[ShadowOwl]

Here's another problem I've noticed:

Whenever there's a 3D model shown during the briefings the game will crash during the load screen after launching the mission. This s happening with or without the XWAU Craft pack 1.1 being installed, GOG version being used with the renderer by JérémyaFr. Any known causes or fixes for this?

[Darksaber]

Sorry this is the first I've heard of this, if you say its with out without the XWAUCP then that's a relief it must be something GOG may have done

[JeremyaFr]

A workaround for this problem was provided by DTM.

Can you give details about the crash?

[ShadowOwl]

A workaround for this problem was provided by DTM.

Can you give details about the crash?

I have attached the crash report from the Windows Event Manager as XML. I'll do some further testing.
Same problem as reported here btw: viewtopic.php?f=15&t=11254

[JeremyaFr]

Same problem as reported here btw: viewtopic.php?f=15&t=11254

You're right. It's exactly the same problem.

[JeremyaFr]

Is'nt there something wrong with the wireframe overlay?

Original model:

corellian_transport_ext_tg.jpg

Upgraded model:

corellian_transport_ext_up.jpg

[Darksaber]

Is this the cause of the crashing then??

[JeremyaFr]

The crash is related to the briefing wireframe overlay.

There is a bug in the exe that lead to a buffer overflow when more than 8000 points are generated.
Starting from 5000 points, there are missing parts. Then starting from around 8100 points, the game crashes in the hangar.

A workaround is to disable the briefing wireframe overlay:

Code: Select all

At offset 07E09C, replace 7D with EB
At offset 07E12E, replace 7D with EB
At offset 07E1B9, replace 47 with 90

The result is:

briefing_wireframe_overlay_off.jpg

[Reimar]

Those modifications seem to be around the checks to 5000 points limit. Did you check/figure out why they don't work properly?
Just so I know if it's a complete waste of time if I try and have a look at it.

[JeremyaFr]

The checks are fine (just limiting). The problem is around the third modification. There is no check here.
I think the simplest way to solve that and to remove the limit would be to transform the static arrays into dynamic ones.
I wonder if there is a point to do that and if the animation would still be good with a lots of faces.